Skip to content

Hide banner on scroll#60

Merged
amrabed merged 1 commit into
mainfrom
fix-banner-scroll-14657096704215893863
May 23, 2026
Merged

Hide banner on scroll#60
amrabed merged 1 commit into
mainfrom
fix-banner-scroll-14657096704215893863

Conversation

@google-labs-jules
Copy link
Copy Markdown
Contributor

The banner is now part of the normal document flow (relative positioning), so it scrolls away when the user scrolls down. The sticky header has been adjusted to remove the 40px top padding and height offset that were previously reserved for the fixed banner, ensuring it sticks correctly to the top of the viewport.


PR created automatically by Jules for task 14657096704215893863 started by @amrabed

- Updated Banner component to use relative positioning instead of fixed.
- Adjusted MainHeader to remove top padding and reduce height, allowing it to correctly stick to the top of the viewport once the banner has scrolled out of view.
@google-labs-jules
Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sonarqubecloud
Copy link
Copy Markdown

@amrabed amrabed marked this pull request as ready for review May 23, 2026 21:02
@amrabed amrabed merged commit 56f79c2 into main May 23, 2026
5 checks passed
@amrabed amrabed deleted the fix-banner-scroll-14657096704215893863 branch May 23, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant